Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-749232: Upgrade to aws-sdk v3 #616

Merged
merged 2 commits into from
Sep 15, 2023
Merged

SNOW-749232: Upgrade to aws-sdk v3 #616

merged 2 commits into from
Sep 15, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

aws-sdk v2 causes warning message:

(node:39752) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use `node --trace-warnings ...` to show where the warning was created)

and we should switch to AWS SDK in version 3.

AWS SDK v3 needs Node version >=14

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-749232-upgrade-to-aws-sdk-v3 branch 3 times, most recently from 3ff0df4 to 6ccb645 Compare August 16, 2023 09:38
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Aug 16, 2023
Closed
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-749232-upgrade-to-aws-sdk-v3 branch 2 times, most recently from 65089d9 to 1f48ff6 Compare August 21, 2023 09:42
@sahilkul95
Copy link

@sfc-gh-pfus @sfc-gh-igarish
Can we please prioritize this? We are blocked for only one upgrade.

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-749232-upgrade-to-aws-sdk-v3 branch from 1f48ff6 to f806155 Compare August 23, 2023 05:25
@sfc-gh-dprzybysz
Copy link
Collaborator Author

@sfc-gh-pfus @sfc-gh-igarish Can we please prioritize this? We are blocked for only one upgrade.

We are planning to include it in the next month release

@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as ready for review August 30, 2023 05:27
@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner August 30, 2023 05:27
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Aug 30, 2023
View reviewed changes
lib/file_transfer_agent/s3_util.js Outdated Show resolved Hide resolved
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-749232-upgrade-to-aws-sdk-v3 branch from f806155 to 7fd1690 Compare August 30, 2023 08:13
@awhitford awhitford mentioned this pull request Sep 5, 2023
Closed
@sahilkul95
Copy link

Hi team, are we planning to release this in this month? Any updates?

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 472c467 into master Sep 15, 2023
31 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-749232-upgrade-to-aws-sdk-v3 branch September 15, 2023 08:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-dprzybysz @sahilkul95 @sfc-gh-pmotacki @sfc-gh-pfus