Skip to content

Commit

Permalink
Common: Bump to JDK 11 (close #362)
Browse files Browse the repository at this point in the history
  • Loading branch information
oguzhanunlu committed Sep 24, 2020
1 parent 1e937a1 commit 4ec2443
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 510 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Set up JDK 1.8
- name: Set up JDK 11
uses: actions/setup-java@v1
with:
java-version: 1.8
java-version: 11
- name: Prepare Mock server for SCE ApiRequestEnrichmentIntegrationTest (launch in background)
run: python integration-tests/sce-api-lookup-test.py 8001 &
- name: Prepare Postgres for SCE SqlLookupEnrichmentIntegrationTest (create entities)
Expand Down Expand Up @@ -55,10 +55,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up JDK 1.8
- name: Set up JDK 11
uses: actions/setup-java@v1
with:
java-version: 1.8
java-version: 11
- name: Compare SBT version with git tag
run: .github/check_tag.sh ${GITHUB_REF##*/}
- name: Docker login
Expand All @@ -81,10 +81,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up JDK 1.8
- name: Set up JDK 11
uses: actions/setup-java@v1
with:
java-version: 1.8
java-version: 11
- name: Compare SBT version with git tag
run: .github/check_tag.sh ${GITHUB_REF##*/}
- name: Deploy SCE on Bintray Maven and Maven Central
Expand Down
1 change: 0 additions & 1 deletion .jvmopts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@
-XX:+TieredCompilation
-XX:-UseGCOverheadLimit
# effectively adds GC to Perm space
-XX:+UseConcMarkSweepGC
-XX:+CMSClassUnloadingEnabled
# must be enabled for CMSClassUnloadingEnabled to work
13 changes: 2 additions & 11 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
lazy val root = project.in(file("."))
.settings(name := "enrich")
.settings(BuildSettings.basicSettings)
.aggregate(common, beam, stream, kinesis, kafka, nsq, stdin, integrationTests)
.aggregate(common, beam, stream, kinesis, kafka, nsq, stdin)

lazy val common = project
.in(file("modules/common"))
Expand Down Expand Up @@ -178,13 +178,4 @@ lazy val beam =
)
.enablePlugins(JavaAppPackaging, DockerPlugin, BuildInfoPlugin)

lazy val integrationTests = project
.in(file("modules/integration-tests"))
.settings(moduleName := "integration-tests")
.settings(allStreamSettings)
.settings(BuildSettings.addExampleConfToTestCp)
.settings(libraryDependencies ++= Seq(
Dependencies.Libraries.kafka,
Dependencies.Libraries.jinJava
))
.dependsOn(stream % "test->test", kafka % "test->compile")
Global / onChangedBuildSource := ReloadOnSourceChanges
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ object YauaaEnrichmentSpec {
"event_format" -> "jsonschema",
"event_version" -> "1-0-0",
"event" -> "page_ping",
"derived_contexts" -> json"""{"schema":"iglu:com.snowplowanalytics.snowplow/contexts/jsonschema/1-0-1","data":[{"schema":"iglu:nl.basjes/yauaa_context/jsonschema/1-0-1","data":{"deviceBrand":"Unknown","deviceName":"Desktop","operatingSystemVersionMajor":"7","layoutEngineNameVersion":"Gecko 12.0","operatingSystemNameVersion":"Windows 7","layoutEngineBuild":"20100101","layoutEngineNameVersionMajor":"Gecko 12","operatingSystemName":"Windows NT","agentVersionMajor":"12","layoutEngineVersionMajor":"12","deviceClass":"Desktop","agentNameVersionMajor":"Firefox 12","operatingSystemNameVersionMajor":"Windows 7","deviceCpuBits":"64","operatingSystemClass":"Desktop","layoutEngineName":"Gecko","agentName":"Firefox","agentVersion":"12.0","layoutEngineClass":"Browser","agentNameVersion":"Firefox 12.0","operatingSystemVersion":"7","deviceCpu":"Intel x86_64","agentClass":"Browser","layoutEngineVersion":"12.0"}}]}""".noSpaces)
"derived_contexts" -> json"""{"schema":"iglu:com.snowplowanalytics.snowplow/contexts/jsonschema/1-0-1","data":[{"schema":"iglu:nl.basjes/yauaa_context/jsonschema/1-0-1","data":{"deviceBrand":"Unknown","deviceName":"Desktop","operatingSystemVersionMajor":"7","layoutEngineNameVersion":"Gecko 12.0","operatingSystemNameVersion":"Windows 7","layoutEngineBuild":"20100101","layoutEngineNameVersionMajor":"Gecko 12","operatingSystemName":"Windows NT","agentVersionMajor":"12","layoutEngineVersionMajor":"12","deviceClass":"Desktop","agentNameVersionMajor":"Firefox 12","operatingSystemNameVersionMajor":"Windows 7","deviceCpuBits":"64","operatingSystemClass":"Desktop","layoutEngineName":"Gecko","agentName":"Firefox","agentVersion":"12.0","layoutEngineClass":"Browser","agentNameVersion":"Firefox 12.0","operatingSystemVersion":"7","deviceCpu":"Intel x86_64","agentClass":"Browser","layoutEngineVersion":"12.0"}}]}""".noSpaces
)
}

class YauaaEnrichmentSpec extends PipelineSpec {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ class EnrichedEventSpec extends Specification {
testField(_.event_version = "event_version", _.event_version)
testField(_.event_fingerprint = "event_fingerprint", _.event_fingerprint)
testField(_.true_tstamp = "true_tstamp", _.true_tstamp)

}
}

Expand Down

This file was deleted.

Loading

0 comments on commit 4ec2443

Please sign in to comment.