Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: get rid of Eval instances #300

Closed
chuwy opened this issue Jul 28, 2020 · 0 comments
Closed

Common: get rid of Eval instances #300

chuwy opened this issue Jul 28, 2020 · 0 comments
Assignees
@chuwy
Labels
under the hood
Milestone
1.4.0

Comments

@chuwy
Copy link
Contributor

chuwy commented Jul 28, 2020

Most of tests use Eval instead of Id, but in runtime we always stick to Id. We should be using Id because a) it's closer to production and b) Eval is just not designed as an effect.
@chuwy chuwy added this to the 1.4.0 milestone Jul 28, 2020
@chuwy chuwy self-assigned this Jul 29, 2020
chuwy added a commit that referenced this issue Aug 19, 2020
@chuwy
Common: get rid of Eval instances (close #300)
eb26b5b
chuwy added a commit that referenced this issue Aug 20, 2020
@chuwy
Common: get rid of Eval instances (close #300)
3fb482e
chuwy added a commit that referenced this issue Aug 20, 2020
@chuwy
Common: get rid of Eval instances (close #300)
e85e870
chuwy added a commit that referenced this issue Sep 15, 2020
@chuwy
Common: get rid of Eval instances (close #300)
d31d2dc
@chuwy chuwy closed this as completed in 024e2c8 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuwy chuwy

Labels
under the hood
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
1 participant
@chuwy