Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: fix flaky ThriftLoader test #306

Closed
dilyand opened this issue Jul 30, 2020 · 1 comment
Closed

Common: fix flaky ThriftLoader test #306

dilyand opened this issue Jul 30, 2020 · 1 comment
Assignees
Milestone

Comments

@dilyand
Copy link
Contributor

dilyand commented Jul 30, 2020

$e2 in ThriftLoaderSpec has erratic behaviour. It usually passes but sometimes can fail, like in:

[info] ThriftLoaderSpec
[info]   + toCollectorPayload should return a CollectorPayload for a valid Thrift CollectorPayload (even if parameterless)
[error]   x toCollectorPayload should return a Validation Failure for an invalid or corrupted Thrift CollectorPayload
[error]  Falsified after 79 passed tests.
[error]  > ARG_0: "/3"
[error]  > ARG_0_ORIGINAL: "㮘칂앛拪㲹芛먋礦/䭈㎵擧밯3摐㯡婓좁✣ퟖ뫝딨诩吞뒦쐊赩酼풎ᅰ"
[error]  The seed is 3eIWhEidqcaUYtTXZXsFGlGEsZtRSNPtxhAu3jEpH6G=
[error]  
[error]  > Invalid(NonEmptyList(CPFormatViolation(Processor(ThriftLoaderSpec,v1),CPFormatViolation(2020-07-30T07:10:59.129Z,thrift,Fallback(error deserializing raw event: Cannot read. Remote side has closed. Tried to read 2 bytes, but only got 0 bytes. (This is often indicative of an internal error on the server side. Please check your server logs.))),RawPayload(/w==)))) is Invalid but Fallback(error deserializing raw event: Cannot read. Remote side has closed. Tried to read 2 bytes, but only got 0 bytes. (This is often indicative of an internal error on the server side. Please check your server logs.)) != Fallback(error deserializing raw event: Cannot read. Remote side has closed. Tried to read 1 bytes, but only got 0 bytes. (This is often indicative of an internal error on the server side. Please check your server logs.)) (ThriftLoaderSpec.scala:185)
[error] Actual:   ...read [2] byte...
[error] ...gs.))
[error] Expected: ...read [1] byte...
[error] ...gs.))
[info] Total for specification ThriftLoaderSpec
[info] Finished in 655 ms
[info] 2 examples, 1 failure, 0 error
@chuwy
Copy link
Contributor

chuwy commented Aug 9, 2020

The message needs to assume "2 bytes" as well as "1 bytes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants