Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: fix number deserialization in API Request Enrichment #383

Closed
oguzhanunlu opened this issue Oct 27, 2020 · 0 comments
Closed

Common: fix number deserialization in API Request Enrichment #383

oguzhanunlu opened this issue Oct 27, 2020 · 0 comments
Assignees
@oguzhanunlu
Milestone
1.4.1

Comments

@oguzhanunlu
Copy link
Member

oguzhanunlu commented Oct 27, 2020 •
edited
Loading

Currently numbers with fractional values are deserialized to string whereas it should be number. This happens at JsonPath.convertToJson where jackson maps JsonDecimal to String, not Double or Float. This results in bad events with error message string found, number expected.

Also, Enrich codebase uses both jawn and jackson to parse Circe AST in different places. Their semantics are different.
@oguzhanunlu oguzhanunlu added this to the 1.4.1 milestone Oct 27, 2020
@oguzhanunlu oguzhanunlu self-assigned this Oct 27, 2020
oguzhanunlu added a commit that referenced this issue Oct 27, 2020
@oguzhanunlu
Common: fix number deserialization in API Request Enrichment (close #383
1857866 
)
oguzhanunlu added a commit that referenced this issue Oct 28, 2020
@oguzhanunlu
Common: fix number deserialization in API Request Enrichment (close #383
8b136d3 
)
oguzhanunlu added a commit that referenced this issue Oct 28, 2020
@oguzhanunlu
Common: fix number deserialization in API Request Enrichment (close #383
95975a3 
)
oguzhanunlu added a commit that referenced this issue Oct 28, 2020
@oguzhanunlu
Common: fix number deserialization in API Request Enrichment (close #383
ff5819b 
)
oguzhanunlu added a commit that referenced this issue Oct 28, 2020
@oguzhanunlu
Common: fix number deserialization in API Request Enrichment (close #383
12727ee 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oguzhanunlu oguzhanunlu

Labels
None yet
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
1 participant
@oguzhanunlu