Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beam: handle commas in Sentry DSN parameter #391

Closed
benjben opened this issue Nov 4, 2020 · 0 comments
Closed

Beam: handle commas in Sentry DSN parameter #391

benjben opened this issue Nov 4, 2020 · 0 comments
Assignees
@benjben
Labels
bug Something isn't working
Milestone
1.4.2

Comments

@benjben
Copy link
Contributor

benjben commented Nov 4, 2020 •
edited
Loading

ATM if --sentry-dsn= parameter contains a ,, which is needed for tags, Beam Enrich crashes with :

java.lang.IllegalArgumentException: Multiple values for property 'sentry-dsn'
     at com.spotify.scio.Args.optional(Args.scala:106)
     at com.snowplowanalytics.snowplow.enrich.beam.config$EnrichConfig$.$anonfun$apply$4(config.scala:80)
     at scala.util.Either.map(Either.scala:353)
     at com.snowplowanalytics.snowplow.enrich.beam.config$EnrichConfig$.$anonfun$apply$1(config.scala:62)
     at scala.util.Either.flatMap(Either.scala:341)
     at com.snowplowanalytics.snowplow.enrich.beam.config$EnrichConfig$.apply(config.scala:61)
     at com.snowplowanalytics.snowplow.enrich.beam.ConfigSpec.$anonfun$new$12(ConfigSpec.scala:140)
     at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
     at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
     at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)

due to args.optional() on an argument which is a List().
@benjben benjben added the bug Something isn't working label Nov 4, 2020
@benjben benjben self-assigned this Nov 4, 2020
benjben added a commit that referenced this issue Nov 4, 2020
@benjben
Beam: handle commas in Sentry DSN parameter (close #391)
1e44917
benjben added a commit that referenced this issue Nov 5, 2020
@benjben
Beam: handle commas in Sentry DSN parameter (close #391)
415e00a
benjben added a commit that referenced this issue Nov 11, 2020
@benjben
Beam: handle commas in Sentry DSN parameter (close #391)
c269274
benjben added a commit that referenced this issue Nov 17, 2020
@benjben
Beam: handle commas in Sentry DSN parameter (close #391)
96d90f6
@chuwy chuwy added this to the 1.4.2 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjben benjben

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
2 participants
@chuwy @benjben