Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump snyk-docker-plugin. Added pull if image isn't local logic #1020

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

RotemS
Copy link
Contributor

@RotemS RotemS commented Feb 25, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Bumped snyk-docker-plugin. This version includes logic that when using snyk test --docker <docker image>, if the image doesn't exist locally, it will be pulled if possible and then scanned.

Previously this used to fail and show an error that the image doesn't exist, but still pull the image in the background (without indication).

@RotemS RotemS requested a review from a team as a code owner February 25, 2020 08:45
@RotemS RotemS self-assigned this Feb 25, 2020
@RotemS RotemS force-pushed the feat/pull-image-if-not-local branch from a8c88a9 to bd79fc2 Compare February 25, 2020 08:51
Copy link
Contributor

@aviadhahami aviadhahami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@gitphill gitphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally with snyk test --docker alpine looks good, pulls in image

@RotemS RotemS merged commit 1b8933e into master Feb 25, 2020
@RotemS RotemS deleted the feat/pull-image-if-not-local branch February 25, 2020 11:08
@snyksec
Copy link

snyksec commented Feb 25, 2020

🎉 This PR is included in version 1.297.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants