Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poc: add snykcode to the cli #1604

Closed
wants to merge 8 commits into from
Closed

poc: add snykcode to the cli #1604

wants to merge 8 commits into from

Conversation

j-sp4
Copy link
Contributor

@j-sp4 j-sp4 commented Feb 1, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@j-sp4 j-sp4 requested a review from ArturSnyk February 1, 2021 13:03
@j-sp4 j-sp4 self-assigned this Feb 1, 2021
@ArturSnyk ArturSnyk force-pushed the poc/add-sast-functionality branch 4 times, most recently from 45c01ce to e33dd2c Compare February 14, 2021 19:26
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2021 •
edited
Loading

Fails
🚫

Commit "poc: add snykcode to the cli" is not a valid commitizen message. See Contributing page with required commit message format.
🚫

Commit "poc: add snykcode to the cli" is not a valid commitizen message. See Contributing page with required commit message format.
Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 8f7235c

@ArturSnyk ArturSnyk force-pushed the poc/add-sast-functionality branch 2 times, most recently from 7318c28 to 9e197a6 Compare February 15, 2021 09:00
@github-actions
Copy link
Contributor

Expected release notes (by @ArturSnyk)

features:
add sarif validation and show rule name instaed of id (32764d2)
more formating, and exit code support (a3bb8ed)

others (will not be included in Semantic-Release notes):
remove sarif validaiton atm (8f7235c)
remove redundant formating steps on code scanning part (50f2230)
linting (2d7d76c)
rebasing (c2a87b1)
add snykcode to the cli (2583025)
add snykcode to the cli (2e53647)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ArturSnyk ArturSnyk closed this Mar 2, 2021
@ArturSnyk
Copy link
Contributor

closed in favor of #1664

@ArturSnyk ArturSnyk deleted the poc/add-sast-functionality branch March 2, 2021 13:10
This was referenced Apr 26, 2021
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2023
Open
@aliscco aliscco mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturSnyk ArturSnyk Awaiting requested review from ArturSnyk

Assignees

@j-sp4 j-sp4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-sp4 @ArturSnyk