Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SARIF support for snyk open-source #1622

Merged
merged 1 commit into from
Feb 9, 2021
Merged

feat: add SARIF support for snyk open-source #1622

merged 1 commit into from
Feb 9, 2021

Conversation

admons
Copy link
Contributor

@admons admons commented Feb 8, 2021 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add "--sarif" option to Snyk Open Source

Here's a screenshot from Github code scanning with the result of the --sarif run

image

@admons admons requested review from a team as code owners February 8, 2021 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021 •
edited
Loading

Warnings
⚠️

Looks like you added a new Tap test. Consider making it a Jest test instead. See files like test/*.spec.ts for examples. Files found:

  • test/support/sarif-schema-2.1.0.js

Generated by 🚫 dangerJS against a3ec441

@admons admons marked this pull request as draft February 8, 2021 13:29
@admons admons force-pushed the feat/open-source-sarif branch 3 times, most recently from 8ff359a to 89e80be Compare February 8, 2021 16:59
@admons admons requested a review from orsagie February 8, 2021 16:59
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021 •
edited by orsagie
Loading

Expected release notes (by @admons)

features:
add SARIF support for snyk open-source (a3ec441)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@admons admons marked this pull request as ready for review February 8, 2021 19:08
orsagie
orsagie approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@orsagie orsagie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatTM

@admons admons merged commit c7374f5 into master Feb 9, 2021
@admons admons deleted the feat/open-source-sarif branch February 9, 2021 05:54
@snyk-bot snyk-bot mentioned this pull request Jan 18, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 31, 2022
Closed
@EitanGayor EitanGayor mentioned this pull request Feb 20, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Feb 20, 2023
Open
@AliADDOU AliADDOU mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsagie orsagie orsagie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@admons @orsagie