Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash with lodash subpackages #1634

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Replace lodash with lodash subpackages #1634

merged 1 commit into from
Feb 12, 2021

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Feb 12, 2021

This PR limits the usage of lodash package, in favor of lodash.<module> packages.

Also adds an eslint rule to prevent lodash being used again.

@JackuB JackuB marked this pull request as ready for review February 12, 2021 13:24
@JackuB JackuB requested a review from a team as a code owner February 12, 2021 13:24
@JackuB JackuB requested a review from a team February 12, 2021 13:24
@JackuB JackuB requested a review from a team as a code owner February 12, 2021 13:24
aron
aron approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@aron aron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @snyk/cloudconfig files

test/acceptance/cli-test/iac/cli-test.iac-utils.ts Show resolved Hide resolved
@JackuB JackuB force-pushed the fix/use-method-specific-lodash-packages branch from f76aba6 to 9300b9e Compare February 12, 2021 14:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2021 •
edited by JackuB
Loading

Expected release notes (by @JackuB)

fixes:
replace lodash with lodash subpackages (9300b9e)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

maxjeffos
maxjeffos approved these changes Feb 12, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@JackuB JackuB merged commit fd7d559 into master Feb 12, 2021
@JackuB JackuB deleted the fix/use-method-specific-lodash-packages branch February 12, 2021 15:21
@nathan-snyk nathan-snyk mentioned this pull request Jun 21, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 21, 2023
Open
@aliscco aliscco mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aron aron aron approved these changes

@gitphill gitphill gitphill approved these changes

@maxjeffos maxjeffos maxjeffos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackuB @aron @gitphill @maxjeffos