Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore node_modules in the packages #1686

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

maxjeffos
Copy link
Contributor

@maxjeffos maxjeffos commented Mar 5, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Ignore node_modules folders in the root of a package (/packages/<package-name>/node_modules). This will NOT ignore other node_modules such as those used in test fixtures (ex /packages/<package-name>/test/fixtures...)

Any background context you want to provide?

The node_modules generated by npm install in the root of the new snyk-fix package is not being ignored.

@maxjeffos maxjeffos requested review from a team as code owners March 5, 2021 16:11
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 6897a45

@@ -1,6 +1,7 @@
config.local.json
/.nyc_output/
/node_modules/
/packages/*/node_modules/
Copy link

@ghost ghost Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better represent intent here, it might be worth ignoring all node_modules and then adding an exception for fixtures. But this isn't blocking, just an idea, as ignoring all node_modules is generally considered default behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant