[COD-152] feat: analytics added to snykcode flow #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiila
approved these changes
Mar 17, 2021
| @@ -25,6 +26,7 @@ export const codePlugin: EcosystemPlugin = { | |||
| async test(paths, options) { | |||
| try { | |||
| await validateCodeTest(options); | |||
| analytics.add('sast-scan', true); | |||
There was a problem hiding this comment.
question: I have a vague memory of these things being required somewhere else. Did you discuss it with somebody who has more BI insights?
There was a problem hiding this comment.
Yes, those keys needs to be defined in registry src/lib/analytics/cli.ts, because we are not collecting free-form analytics keys anymore… for reasons
j-sp4
force-pushed
the
feat/add-analytics-snyk-code
branch
2 times, most recently
from
abc9fc9
to
a442e80
Compare
j-sp4
force-pushed
the
feat/add-analytics-snyk-code
branch
3 times, most recently
from
928223c
to
e3d058f
Compare
j-sp4
changed the title
JackuB
approved these changes
Mar 30, 2021
JackuB
reviewed
Mar 30, 2021
j-sp4
force-pushed
the
feat/add-analytics-snyk-code
branch
from
e3d058f
to
143c363
Compare
j-sp4
force-pushed
the
feat/add-analytics-snyk-code
branch
from
143c363
to
4e8e35b
Compare
|
Expected release notes (by @Spoor2709) features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COD-152
What does this PR do?
The pr adds analytics to snykcode flow in the cli