Add typescript #216
Add typescript #216
Conversation
miiila
force-pushed
the
chore/typescript-cli
branch
14 times, most recently
from
11199d3
to
b8edc07
Compare
miiila
force-pushed
the
chore/typescript-cli
branch
from
b8edc07
to
bdf2554
Compare
|
Let's not make this all |
|
think now we should update |
| "eslint": "^4.11.0", | ||
| "nock": "^9.2.5", | ||
| "proxyquire": "^1.7.4", | ||
| "restify": "^4.1.1", | ||
| "sinon": "^1.17.2", | ||
| "strip-ansi": "^4.0.0", | ||
| "tap": "^12.0.0", | ||
| "tap-only": "0.0.5", |
There was a problem hiding this comment.
maybe if you remove tap-only, can also remove the check-tests scripts above? as it's purpose it to check for only() accidently commited
There was a problem hiding this comment.
@michael-go tap supports .only() as well (https://www.node-tap.org/only/), that's why I have left it.
| "tap-only": "0.0.5", | ||
| "tape": "^4.0.0" | ||
| "tap": "github:snyk/node-tap#alternative-runtimes", | ||
| "tape": "^4.0.0", |
There was a problem hiding this comment.
is tape really needed? maybe it can easily be replaced with tap?
There was a problem hiding this comment.
TBH, I don't know, but don't want to do this decision now :-)
|
@adrukh In my opinion - it's not a functional change and we should be confident we haven't broken anything. I also believe that adoption of CLI tool is not as fast as it happens in SaaS enviroment, so we would get a feedback after a while. Therefore, I don't believe feedback in a way Additionally, if we would publish a new version ( with functional change) in the meantime and there would be a problem - what's a safe version for a rollback? |
src/cli/index.ts
Outdated
| if (!runtime.isSupported(process.versions.node)) { | ||
| console.error(process.versions.node + | ||
| ' is an unsupported nodejs runtime! Supported runtime range is \'' + | ||
| runtime.supportedRange + '\''); | ||
| console.error('Please upgrade your nodejs runtime version ' + | ||
| 'and try again.'); | ||
| process.exit(1); | ||
| }; | ||
| } |
There was a problem hiding this comment.
with real ES6 modules (which is not the case here, but might be in the future with node 10), all the imports happen before the the script starts, so I think it's better to put all imports on top before any code to be more clear about it.
miiila
force-pushed
the
chore/typescript-cli
branch
from
f8ef17b
to
c5ebbff
Compare
|
🎉 This PR is included in version 1.97.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Introducing TypeScript will happen in
32 phases (flow verified inregistry):libandclimapping works before/after compilationThis PR introduces typescript support for source files and tests. One source file and test are converted in order to verify everything works as intended.
As a side effect,
package-lock.jsonwas added andnpm prunewas removed from Travis setup.* Sourcode and tests had to be merged together, because conversion of one file led to different requires in tests