fix: move constants for test-unpublished to json and add it to packag… #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Kirill89
force-pushed
the
fix/unpublished
branch
from
2a7338e
to
242a7c9
Compare
3 tasks
|
Looking good, just playing around with it locally. |
lili2311
requested changes
Oct 3, 2018
| .split('\n').map(function (s) { | ||
| return s.trim(); | ||
| }); | ||
| var config = JSON.parse( |
There was a problem hiding this comment.
we can move away form using var now, perhaps lets update this to const
| var tail = fs.readFileSync(__dirname + '/tail.txt', 'utf8'); | ||
| var lbl = fs.readFileSync(__dirname + '/head.txt', 'utf8'); | ||
| var packages = config.packages; | ||
| var tail = config.tail; |
There was a problem hiding this comment.
we can update this to be const { packages, tail, head:lbl } = config; since we can now play around with newer syntax
Kirill89
force-pushed
the
fix/unpublished
branch
from
b592f2c
to
18c5fbf
Compare
Kirill89
force-pushed
the
fix/unpublished
branch
from
f42a1d8
to
53f1c49
Compare
|
@lili2311 fixed. |
lili2311
approved these changes
Oct 3, 2018
|
🎉 This PR is included in version 1.100.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 31, 2020
This was referenced Nov 30, 2022
This was referenced Nov 30, 2022
This was referenced Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e #225
Any background context you want to provide?
Constants for test-unpublished command was in txt file and wasn't included to the npm package.
What are the relevant tickets?
https://github.com/snyk/snyk/issues/225
#226