Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: '--gradle-sub-project' option to handle multip-project gradle #234

Merged
merged 1 commit into from
Oct 7, 2018

Conversation

michael-go
Copy link
Contributor

@michael-go michael-go commented Oct 7, 2018

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

This bumps snyk-gradle-plugin to version 2.1.0 that supports the new flag: https://github.com/snyk/snyk-gradle-plugin/releases/tag/v2.1.0 (PR: snyk/snyk-gradle-plugin#18)

note this also appends the sub-project name to the root package name:

image

@michael-go michael-go self-assigned this Oct 7, 2018
@michael-go michael-go force-pushed the feat/gradle-sub-project-option branch from 6fd5e5d to de73eb6 Compare October 7, 2018 10:10
help/help.txt Outdated
--gradle-sub-project=<string>
For Gradle "multi project" configurations,
specify a desired sub-project to target.
Calls `gradle [sub-proj:]dependencies` under-the-hood.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe without this part, as it is an implementation detail that belongs to the plugin? May change in the future or something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... to target. -> ... to test.?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Gradle "multi project" configurations, test a specific sub-project.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sounds better

note this also appends the sub-project name to the root package name
@michael-go michael-go force-pushed the feat/gradle-sub-project-option branch from de73eb6 to e986f79 Compare October 7, 2018 10:17
@michael-go michael-go merged commit 974949e into master Oct 7, 2018
@michael-go michael-go deleted the feat/gradle-sub-project-option branch October 7, 2018 10:26
@snyksec
Copy link

snyksec commented Oct 7, 2018

🎉 This PR is included in version 1.101.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants