Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proper colour for displaying critical issues/CVEs #2415

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

danlucian
Copy link
Member

What does this PR do?

Bump the version of the cpp plugin from 2.13.0 to 2.14.0 (https://github.com/snyk/snyk-cpp-plugin/releases/tag/v2.14.0).

Any background context you want to provide?

In the version 2.14.0 of the cpp plugin we added support for displaying the critical vulnerabilities.

Screenshots

Screenshot 2021-12-02 at 11 35 10

@danlucian danlucian requested a review from a team as a code owner December 3, 2021 14:16
@danlucian danlucian self-assigned this Dec 3, 2021
@danlucian danlucian requested review from a team, florindumitrascu and anthogez and removed request for a team December 3, 2021 14:17
Copy link
Member

@anthogez anthogez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here @danlucian!
Small suggestion:

Rephrase the commit message to highlight the changes applied into snyk-cpp-plugin
also add the same github notes/message from the pull request that generated the release v2.14.0 of snyk-cpp-plugin.

By adding it into this pr's commit message. Thanks! 🙏

- add the proper colour for displaying the critical CVEs in the CLI
- bump the cpp plugin version
@danlucian danlucian force-pushed the fix/bump-unmanaged-cpp-plugin-version branch from d13b471 to 17c62e8 Compare December 3, 2021 15:03
@danlucian danlucian changed the title fix: bump cpp plugin version for unmanaged fix: add proper colour for displaying critical issues/CVEs Dec 3, 2021
@danlucian
Copy link
Member Author

Nice work here @danlucian! Small suggestion:

Rephrase the commit message to highlight the changes applied into snyk-cpp-plugin also add the same github notes/message from the pull request that generated the release v2.14.0 of snyk-cpp-plugin.

By adding it into this pr's commit message. Thanks! 🙏

Hi there, I just did that, thank you! 🙏
Is there a convention in doing this? I didn't see it mentioned here: https://github.com/snyk/snyk/blob/master/.github/CONTRIBUTING.md (neither in other PRs, I used this as a guideline for example: #2377)

@danlucian danlucian merged commit 2b90580 into master Dec 3, 2021
@danlucian danlucian deleted the fix/bump-unmanaged-cpp-plugin-version branch December 3, 2021 15:51
@anthogez
Copy link
Member

anthogez commented Dec 4, 2021

Nice work here @danlucian! Small suggestion:
Rephrase the commit message to highlight the changes applied into snyk-cpp-plugin also add the same github notes/message from the pull request that generated the release v2.14.0 of snyk-cpp-plugin.
By adding it into this pr's commit message. Thanks! 🙏

Hi there, I just did that, thank you! 🙏 Is there a convention in doing this? I didn't see it mentioned here: https://github.com/snyk/snyk/blob/master/.github/CONTRIBUTING.md (neither in other PRs, I used this as a guideline for example: #2377)

https://github.com/snyk/snyk/blob/master/.github/CONTRIBUTING.md

@danlucian this might be outdated, we should definitely update it.
As commits should be the source of truth, not the GitHub notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants