feat: Include devDependencies in default test from Wizard #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed broken test 👍 |
adam-moss
changed the title
Add --dev to test script generated during the Wizard process Update internal tests to reflect the same
Niponkong
approved these changes
Sep 13, 2017
|
เมื่อ 13 ก.ย. 2017 08:16 "Niponkong" <notifications@github.com> เขียนว่า
… ***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#26 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUB5_1RNOQIkLGF3QM112-q68pMlkFy-ks5shy0DgaJpZM4IZaaW>
.
|
|
Hi @adam-moss! We've been thinking about this use case a lot, but we don't want to test dev dependencies by default as they are not usually exploitable in production. However, enabling the testing of dev dependencies when the user opts-in to do so (eg when running |
|
Sure, I can rebase and enable |
This was referenced Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(This was previously raised as PR #14 but I... errr... broke it 😊)
Adds --dev to the default
snyk testscript generated by the Wizard.Where should the reviewer start?
How should this be manually tested?
npm init)snyk wizardand allow it to update the test scriptpackage.jsonAny background context you want to provide?
By default
npm installwill include devDependencies unless--productionor the relevant environment variable is set.Therefore it would be sensible to reflect this in the implementation of
snykto ensure consistency.What are the relevant tickets?
Screenshots
Additional questions
wizard detects existing snyk in scripts.testnow fails because of the way it has been implemented. I haven't changed this as I'm unsure if you'd prefer to mock the entire thing.