Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add progress indicator #3221

Merged
merged 1 commit into from
May 11, 2022
Merged

feat: Add progress indicator #3221

merged 1 commit into from
May 11, 2022

Conversation

ofekatr
Copy link
Contributor

@ofekatr ofekatr commented May 9, 2022

What does this PR do?

  • Refactors the code for formatting user messages in the IaC test flow.
  • Adds a check for the quiet flag when determining whether not to include user messages in the test output.

Where should the reviewer start?

src/lib/formatters/iac-output/v2/user-messages.ts

How should this be manually tested?

  • Ensure user messages are not included in the output when providing the quiet option.
  • Ensure the output is not changed as a result of this refactor.

Any background context you want to provide?

  • This PR is separated from a follow up PR for adding a new progress indicator to the IaC test flow (CFG-1757)

What are the relevant tickets?

@ofekatr ofekatr mentioned this pull request May 9, 2022
Merged
1 task
@ofekatr ofekatr force-pushed the chore/refactor-user-messages branch from c56af68 to d24cad9 Compare May 9, 2022 15:48
@ofekatr ofekatr force-pushed the chore/add-progress-indicator-cfg-1757 branch 2 times, most recently from 029abfe to 570c06f Compare May 9, 2022 15:56
@ofekatr ofekatr force-pushed the chore/refactor-user-messages branch from d24cad9 to fbcf6c6 Compare May 9, 2022 15:58
@ofekatr ofekatr force-pushed the chore/add-progress-indicator-cfg-1757 branch 2 times, most recently from 3d22e44 to be64d19 Compare May 9, 2022 16:42
@ofekatr ofekatr force-pushed the chore/refactor-user-messages branch from fbcf6c6 to cac52e9 Compare May 9, 2022 17:03
@ofekatr ofekatr force-pushed the chore/add-progress-indicator-cfg-1757 branch 2 times, most recently from 5b5af4b to 7fc92e3 Compare May 9, 2022 17:23
@ofekatr ofekatr force-pushed the chore/refactor-user-messages branch from cac52e9 to afea1b4 Compare May 10, 2022 09:36
@ofekatr ofekatr force-pushed the chore/add-progress-indicator-cfg-1757 branch 4 times, most recently from 54afd81 to e17aa56 Compare May 10, 2022 11:16
Base automatically changed from chore/refactor-user-messages to master May 10, 2022 11:17
@ofekatr ofekatr force-pushed the chore/add-progress-indicator-cfg-1757 branch from e17aa56 to 5f4969d Compare May 10, 2022 11:17
@ofekatr ofekatr requested a review from YairZ101 May 10, 2022 12:17
@ofekatr ofekatr marked this pull request as ready for review May 10, 2022 12:29
@ofekatr ofekatr requested a review from a team as a code owner May 10, 2022 12:29
@ofekatr ofekatr force-pushed the chore/add-progress-indicator-cfg-1757 branch from 5f4969d to 7035da9 Compare May 11, 2022 11:16
@ofekatr ofekatr force-pushed the chore/add-progress-indicator-cfg-1757 branch from 7035da9 to 764e0ce Compare May 11, 2022 11:30
YairZ101
YairZ101 approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@YairZ101 YairZ101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofekatr ofekatr merged commit 18757fd into master May 11, 2022
@ofekatr ofekatr deleted the chore/add-progress-indicator-cfg-1757 branch May 11, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YairZ101 YairZ101 YairZ101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofekatr @YairZ101