fix: handle errors from /share-results [CFG-2028]

[ipapast]

• Follows CONTRIBUTING rules

What does this PR do?

While investigating https://snyk.zendesk.com/agent/tickets/26894, we noticed that client errors (e.g. HTTP 422) from the IaC share-results endpoint are not communicated to the CLI caller at all.

Example error returned in prod-registry that is not surfaced to users (example with non english chars in tag, but this can be caused by any non Az09 characters):

snyk iac test test/fixtures/iac/terraform/var_deref/nested_var_deref/ --project-tags=client=nαδαδσδαomnom,Team=Cloud --report

InvalidUserInputError: invalid tag value: contains invalid characters
    at assertValidValue (/srv/app/dist/lib/tags/validation.js:36:15)
    at assertValidFields (/srv/app/dist/lib/tags/validation.js:50:34)
    at parse (/srv/app/dist/web/routes/project/tags/parse.js:17:38)
    at /srv/app/dist/web/routes/api/v1/iac-cli-share-results.js:36:39
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Users should see the error in the CLI’s output so that they know they need to do something in order to record project results, otherwise the problem might go un-noticed for some time. The silence can also lead users to believe that it is a backend error, and not an input error.

We will not print the specific validation error as part of this PR - this code is to be refactored in the next weeks so we will re-write this again.

This PR updates the call to share-results to handle all 500 errors (that's what we wrap them with in Registry).

before - the error was silent for the invalid tag:

after

[YairZ101]

Thank you for fixing this :)

[ipapast]

Thank you for fixing this :)

no problem. could you have another look, just added a 2nd commit, I think we should be throwing an error for anything non 200ish - like this: 44381fc

what do you think?

[YairZ101]

I think we should be throwing an error for anything non 200ish - like this: 44381fc

what do you think?

sounds like a good idea