Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add missing composer.lock file #346

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

lirantal
Copy link
Member

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Updates the Snyk CLI help for snyk help file to also include composer.lock as a supported ecosystem

@saschanaz
Copy link
Contributor

saschanaz commented Jan 25, 2019

How can some contributors pass the snyk-auth line? 👀

@lirantal lirantal self-assigned this Jan 26, 2019
@lirantal
Copy link
Member Author

@saschanaz what do you mean? for local development or are you asking about CI in forks?

@adrukh
Copy link
Contributor

adrukh commented Jan 26, 2019

@saschanaz, @lirantal is part of our GH org, and is an internal contributor. His PRs are direct on the repo, not from a forked repo.

Your point regarding difficulty to contribute is well placed, we will see how we can address it.

@lirantal lirantal merged commit 5160c55 into master Jan 26, 2019
@lirantal lirantal deleted the lirantal-composer-lockfile-help branch January 26, 2019 21:16
@snyksec
Copy link

snyksec commented Jan 26, 2019

🎉 This PR is included in version 1.122.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants