Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker options passthrough and adoptopenjdk support #363

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

leongold
Copy link
Contributor

This version contains:
SCM integration dockerfile analysis
adoptopenjdk openjdk binary analysis support
global docker options support

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2019

CLA assistant check
All committers have signed the CLA.

@leongold leongold force-pushed the feat/bump-version branch 3 times, most recently from 803a06b to 3c33f09 Compare February 12, 2019 14:55
@orkamara orkamara changed the title feat: bump snyk-docker-plugin to 1.21.1 feat: bump snyk-docker-plugin to 1.21.2 Feb 12, 2019
Copy link
Contributor

@robcresswell robcresswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a more descriptive commit title please, it forms our release notes

@leongold leongold force-pushed the feat/bump-version branch 2 times, most recently from 8ede9a0 to 3dad634 Compare February 12, 2019 21:13
@leongold
Copy link
Contributor Author

leongold commented Feb 12, 2019

Let's have a more descriptive commit title please, it forms our release notes

I find it hard to come up with a title that contains all of what's introduced in this version; I've tried to be as concise as possible, but

feat: bump snyk-docker-plugin version for SCM integration, docker options, and adoptopenjdk support

still looks too long.

Any suggestions?

@robcresswell
Copy link
Contributor

"bump snyk-docker-plugin version for SCM integration" doesn't matter to the end user of the CLI plugin; stick with "feat: docker options passthrough & adoptopenjdk support" ?

This version contains:
SCM integration dockerfile analysis
adoptopenjdk openjdk binary analysis support
global docker options support
@leongold leongold changed the title feat: bump snyk-docker-plugin to 1.21.2 feat: docker options passthrough and adoptopenjdk support Feb 13, 2019
@orkamara orkamara merged commit dd259d6 into master Feb 13, 2019
@orkamara orkamara deleted the feat/bump-version branch February 13, 2019 07:19
@snyksec
Copy link

snyksec commented Feb 13, 2019

🎉 This PR is included in version 1.127.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants