chore: implement --about #3817
Merged
chore: implement --about #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
force-pushed
the
chore/cliv2_HMMR-532
branch
from
f6d1005
to
08f639a
Compare
Avishagp
reviewed
Sep 5, 2022
PeterSchafer
force-pushed
the
chore/cliv2_HMMR-532
branch
3 times, most recently
from
d15d255
to
2163e2a
Compare
Avishagp
reviewed
Sep 5, 2022
Avishagp
reviewed
Sep 5, 2022
Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: add go license Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: remove placeholder licnese file Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: add simple —about implementation … … combining —about from cliv1 and local output Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: add readme and remove license file Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: update git ignore Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: add generation of 3rd party licenses to Makefile Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: adapt output format of —about Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: adapt go-license usage Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: print license files Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: change installation of go-license Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: fix issue when cross compiling Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: adding manual download for missing licenses Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
PeterSchafer
force-pushed
the
chore/cliv2_HMMR-532
branch
from
2163e2a
to
e712369
Compare
Avishagp
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add golang based licenses to the --about dialog. It adds retrieving the licenses on the fly to the build process, bundles them into the binary and prints them to the end of the typescript based license content.
Where should the reviewer start?
How should this be manually tested?
Run the cli with
--about, pipe the output into a file and compare the output with the same output for the typescript cli