Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not fail if csproj not found #452

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Conversation

orsagie
Copy link
Contributor

@orsagie orsagie commented Apr 18, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Large nuget projects might not have their csproj file next to their obj/project.assets.json file. The paths to each of the files is listed in a properties file that we don't parse yet. Since we don't require the target framework from the csproj, yet, we can stop failing if we can't find the csproj where we expect it. This PR allows such projects to succeed when sending --file=path/to/project.assets.json flag.

Where should the reviewer start?

snyk/snyk-nuget-plugin#52

@orsagie orsagie closed this Apr 18, 2019
@orsagie orsagie reopened this Apr 18, 2019
@orsagie orsagie merged commit f1cfd30 into master Apr 19, 2019
@orsagie orsagie deleted the fix/upgrade-snyk-nuget-plugin branch April 19, 2019 10:37
@snyksec
Copy link

snyksec commented Apr 19, 2019

🎉 This PR is included in version 1.151.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants