chore: add npm dev script #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmars
force-pushed
the
chore/npm-dev-command
branch
from
d34754f
to
5dd69a7
Compare
PeterSchafer
reviewed
Feb 5, 2024
| @@ -43,7 +43,8 @@ | |||
| "test:unit": "jest --runInBand --testPathPattern '/test(/jest)?/unit/'", | |||
| "test:acceptance": "jest --runInBand --testPathPattern '/test(/jest)?/acceptance/'", | |||
| "test:tap": "tap -Rspec --timeout=300 test/tap/*.test.* ", | |||
| "test:smoke": "./scripts/run-smoke-tests-locally.sh" | |||
| "test:smoke": "./scripts/run-smoke-tests-locally.sh", | |||
| "dev": "ts-node ./src/cli/index.ts" | |||
There was a problem hiding this comment.
Suggestion: In order to facilitate the usage of the Makefile, how about adding this to the Makefile? For example like this:
make run // runs the Extensible CLI
make run-ts // runs only the TS/Legacy CLI
There was a problem hiding this comment.
The final goal could be to not be required to use npm calls anymore.
There was a problem hiding this comment.
Added. Both targets check for an ARGS variable, which is used to specify the CLI arguments through make.
There was a problem hiding this comment.
My preference would be to keep the npm script, but also wrap it with make. The npm script is easier to use with a debug launch profile in VSCode, and it inherits the right $PATH.
cmars
force-pushed
the
chore/npm-dev-command
branch
from
5dd69a7
to
576da06
Compare
PeterSchafer
reviewed
Feb 5, 2024
PeterSchafer
reviewed
Feb 5, 2024
To aid in debugging and development of the Typescript parts of the CLI, adding an npm script entrypoint to the CLI. This doesn't run the complete CLI but is useful for isolating and debugging Typescript CLI issues. Added Makefile targets for running the full extensible CLI and TS entrypoint.
cmars
force-pushed
the
chore/npm-dev-command
branch
from
576da06
to
a44ed10
Compare
PeterSchafer
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid in debugging and development of the Typescript parts of the CLI, this adds an npm script entrypoint to the CLI.
This doesn't run the complete CLI but may be useful for isolating and debugging Typescript CLI issues.
This is not a user-facing change.
Usage:
npm run dev testto run the equivalent ofsnyk testfrom Typescript source.npm run dev -- -dto pass the debug-dflag to the Typescript main entrypoint (and notnpm run).