Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Jest, and peer dependencies, to v28 [CLI-124] #5046

Merged
merged 16 commits into from
Feb 19, 2024

Conversation

j-luong
Copy link
Contributor

@j-luong j-luong commented Feb 9, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

This PR updates Jest from Jest@^27 to Jest@^28. Jest peer dependencies were also updated.

Where should the reviewer start?

No new tests written as we're just upgrading dev dependencies, not changing/adding functionality.

Validate behaviour is unchanged. This PR impact only the legacy CLI, but includes a major TypeScript version change.

Risk assessment

Medium

Major version upgrades impact only dev dependencies

How should this be manually tested?

Can be manually tested with a local binary.

  • make clean
  • make build
  • .../binary-releases/snyk-<OS>-<ARCH> <COMMAND> <OPTS>

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@j-luong j-luong changed the title chore: Upgrade Jest to v28 and any peer dependencies chore: Upgrade Jest, and any peer dependencies, to v28 Feb 9, 2024
@j-luong j-luong changed the title chore: Upgrade Jest, and any peer dependencies, to v28 chore: Upgrade Jest, and peer dependencies, to v28 Feb 9, 2024
@j-luong j-luong changed the title chore: Upgrade Jest, and peer dependencies, to v28 chore: Upgrade Jest, and peer dependencies, to v28 [CLI-146] Feb 9, 2024
@j-luong j-luong changed the title chore: Upgrade Jest, and peer dependencies, to v28 [CLI-146] chore: Upgrade Jest, and peer dependencies, to v28 [CLI-124] Feb 9, 2024
@j-luong j-luong mentioned this pull request Feb 9, 2024
10 tasks
@j-luong j-luong force-pushed the chore/CLI-124_upgradeJestDeps branch from 64d41fb to 659209c Compare February 14, 2024 09:24
@thisislawatts thisislawatts changed the base branch from master to main February 16, 2024 09:17
@thisislawatts thisislawatts marked this pull request as ready for review February 16, 2024 09:57
@thisislawatts thisislawatts requested a review from a team as a code owner February 16, 2024 09:57
jest.config.js Show resolved Hide resolved
@j-luong j-luong force-pushed the chore/CLI-124_upgradeJestDeps branch from c176f3a to f9a5f95 Compare February 19, 2024 12:49
@j-luong j-luong enabled auto-merge (squash) February 19, 2024 13:09
@j-luong j-luong enabled auto-merge (squash) February 19, 2024 14:44
@j-luong j-luong force-pushed the chore/CLI-124_upgradeJestDeps branch from ca4b8e4 to 6e1e28d Compare February 19, 2024 16:10
@j-luong j-luong force-pushed the chore/CLI-124_upgradeJestDeps branch from 6e1e28d to 2bbd199 Compare February 19, 2024 17:07
@j-luong j-luong merged commit 74920c0 into main Feb 19, 2024
12 checks passed
@j-luong j-luong deleted the chore/CLI-124_upgradeJestDeps branch February 19, 2024 18:01
PeterSchafer pushed a commit that referenced this pull request Feb 20, 2024
* chore: update ts-node to latest
* chore: upgrade @types/jest
* chore: upgrade jest
* chore: upgrade ts-jest
* chore: upgrade typscript

---------

Co-authored-by: Luke Watts <luke@snyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants