Detect execution inside VSTS/TFS build agent #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This allows CI systems that are currently unsupported to register the environment variable. Prefixed with `SNYK_` to avoid collision with any existing variables in the build pipeline.
lirantal
approved these changes
Nov 18, 2016
| @@ -12,6 +12,7 @@ var ciEnvs = [ | |||
| 'PHPCI', | |||
| 'GOCD_SERVER_HOST', | |||
| 'BUILDKITE', | |||
| 'TF_BUILD' | |||
There was a problem hiding this comment.
@jessehouwing you're missing a trailing comma just like in the coding style used before your change (look at the diff)
|
Thanks @jessehouwing @lirantal ! This is now included in v1.20.0. Outside of this PR's scope due to our internal release process, but you can see the commits on https://github.com/Snyk/snyk/commits/master/lib/is-ci.js |
joshje
referenced
this pull request
in joshje/snyk
Jan 13, 2017
chore: store travis_after_all.py locally
This was referenced Jan 31, 2020
This was referenced Mar 24, 2021
This was referenced Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds the environment variable to detect execution inside the VSTS/TFS build agent.
Where should the reviewer start?
Check the is-ci package, I just added the
TF_BUILDvariable to detect execution inside VSTS/TFS's build agent.How should this be manually tested?
Create an environment variable
TF_BUILDset it's value totruerun
snyk testyou should not see the "You may want to integrate snyk into your CI" message.
Any background context you want to provide?
What are the relevant tickets?
https://github.com/Snyk/snyk/issues/53
https://github.com/Snyk/snyk/issues/58
Screenshots
Additional questions