Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused code #789

Closed
wants to merge 1 commit into from
Closed

Conversation

sujalpatel2209
Copy link

@sujalpatel2209 sujalpatel2209 commented Oct 2, 2019

#788

  • Reviewed by Snyk internal team
  • Ready for review
  • Follows CONTRIBUTING rules

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@sujalpatel2209 sujalpatel2209 requested a review from a team as a code owner October 2, 2019 17:16
@ghost ghost requested review from gitphill and lwywoo October 2, 2019 17:17
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2019

CLA assistant check
All committers have signed the CLA.

@lili2311
Copy link
Contributor

lili2311 commented Oct 3, 2019

@sujalpatel2209 thanks for the contribution, please could you fill out the PR template. You will also need to drop the actual file the command is loading as it won't be reachable anymore :)

@sujalpatel2209
Copy link
Author

sujalpatel2209 commented Oct 4, 2019

@lili2311 Thank You. Can you please giude me how to fill PR tamplate? and remaining task.

@lili2311
Copy link
Contributor

lili2311 commented Oct 7, 2019

  • @sujalpatel2209 please click EDIT at the top there and add the details it is asking for:

Screen Shot 2019-10-07 at 10 37 08

- The file that is imported here: https://github.com//pull/789/files#diff-e64ef427412e9bab4929b8b93ca12d96L27 needs to be dropped too

@lili2311
Copy link
Contributor

👋 Before we can merge this still need to drop the actual code being called, will you be able to check?

@lili2311 lili2311 changed the title remove extra code line chore: delete unused code Nov 5, 2019
@lili2311
Copy link
Contributor

lili2311 commented Nov 5, 2019

@sujalpatel2209 how is this going? Let me know if you need any help :)

@lili2311
Copy link
Contributor

👋 @sujalpatel2209 any luck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants