feat: monitor support for --all-projects #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lili2311
changed the title
lili2311
force-pushed
the
feat/monitor-all-projects
branch
5 times, most recently
from
55887fc
to
0294534
Compare
lili2311
commented
Dec 27, 2019
| @@ -0,0 +1,25 @@ | |||
| import { GoodResult, BadResult } from './types'; | |||
|
|
|||
| export function processJsonMonitorResponse( | |||
lili2311
force-pushed
the
feat/monitor-all-projects
branch
6 times, most recently
from
5bfe017
to
bc65d44
Compare
lili2311
commented
Dec 30, 2019
| // TODO: the type should depend on allSubProjects flag | ||
| const inspectResult: pluginApi.InspectResult = await promiseOrCleanup( | ||
| moduleInfo.inspect(path, targetFile, { ...options }), | ||
| const inspectResult = await promiseOrCleanup( |
lili2311
force-pushed
the
feat/monitor-all-projects
branch
from
bc65d44
to
5f4d918
Compare
dkontorovskyy
force-pushed
the
feat/monitor-all-projects
branch
2 times, most recently
from
c7afcd7
to
702038a
Compare
lili2311
force-pushed
the
feat/monitor-all-projects
branch
4 times, most recently
from
d330103
to
5ade302
Compare
lili2311
commented
Dec 30, 2019
src/cli/commands/monitor/index.ts
Outdated
| } | ||
|
|
||
| throw new Error(json); | ||
| return processJsonMonitorResponse(results); |
lili2311
commented
Dec 30, 2019
lili2311
commented
Dec 30, 2019
lili2311
force-pushed
the
feat/monitor-all-projects
branch
3 times, most recently
from
d018a1c
to
0988aa3
Compare
dkontorovskyy
force-pushed
the
feat/monitor-all-projects
branch
4 times, most recently
from
662cb78
to
573e59d
Compare
lili2311
force-pushed
the
feat/monitor-all-projects
branch
2 times, most recently
from
8dc3a94
to
39deb39
Compare
gitphill
approved these changes
Jan 3, 2020
lili2311
commented
Jan 3, 2020
src/cli/index.ts
Outdated
| 'project-name or file or package-manager or docker', | ||
| 'all-projects', | ||
| ]); | ||
| if (args.options['project-name'] && args.options.allProjects) { |
There was a problem hiding this comment.
maybe this should be a separate function that validates arguments?
lili2311
force-pushed
the
feat/monitor-all-projects
branch
2 times, most recently
from
0b579a7
to
a528b27
Compare
gitphill
reviewed
Jan 3, 2020
package.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "format": "prettier --write '{src,test,scripts}/**/*.{js,ts}'", | |||
| "prepare": "npm run build", | |||
| "test:common": "npm run check-tests && npm run build && npm run lint && node --require ts-node/register src/cli test --org=snyk", | |||
| "test:acceptance": "tap test/acceptance/**/*.test.* -Rspec --timeout=300 --node-arg=-r --node-arg=ts-node/register", | |||
| "test:acceptance": "tap test/acceptance/cli-test/*.test.* -Rspec --timeout=300 --node-arg=-r --node-arg=ts-node/register", | |||
lili2311
force-pushed
the
feat/monitor-all-projects
branch
2 times, most recently
from
f224c20
to
04fe3c4
Compare
lili2311
commented
Jan 3, 2020
| @@ -9,7 +9,7 @@ export function formatTestMeta( | |||
| ): string { | |||
| const padToLength = 19; // chars to align | |||
| const packageManager = res.packageManager || options.packageManager; | |||
| const targetFile = res.targetFile || options.file; | |||
| const targetFile = res.targetFile || res.displayTargetFile || options.file; | |||
There was a problem hiding this comment.
this is used for display purposes and not being sent to the back end
gitphill
force-pushed
the
feat/monitor-all-projects
branch
from
43397fb
to
2318dfc
Compare
Co-authored-by: dkontorovskyy <dan.kontorovskyy@gmail.com>
dkontorovskyy
force-pushed
the
feat/monitor-all-projects
branch
from
2318dfc
to
ba4658a
Compare
|
🎉 This PR is included in version 1.274.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
--all-projectflag is enabled, auto detect => scan and monitor all supported projects (yarn, npm, rubygems, maven) in the given directory only initiallyWhere should the reviewer start?
Relies on this refactor to go in first: #928