Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update env vars in custom rules examples [CFG-1165] #6

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

teodora-sandu
Copy link
Contributor

Required for https://snyksec.atlassian.net/browse/CFG-1165. After snyk/cli#2336, we can use snyk config set and so the environment variables now have a SNYK_CFG_ prefix. These instructions are for CI/CD instructions in GitHub actions, where people would mostly use actual environment variables, not the snyk config set command.

@teodora-sandu teodora-sandu requested review from a team and p15r November 3, 2021 11:05
Copy link

@p15r p15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like a clean naming schema, and the option to supply all configs via env vars as well 😃

@teodora-sandu teodora-sandu merged commit d76945b into main Nov 8, 2021
@teodora-sandu teodora-sandu deleted the chore/update-docs-with-env-vars branch November 8, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants