Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated typescript template #22

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Conversation

Kirill89
Copy link
Contributor

@Kirill89 Kirill89 commented Oct 2, 2018

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

updated typescript template to completely support node 4

Notes for the reviewer

String.prototype.endsWith() not supported by es5.

@Kirill89 Kirill89 requested a review from miiila October 2, 2018 17:41
@Kirill89 Kirill89 self-assigned this Oct 2, 2018
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2018

CLA assistant check
All committers have signed the CLA.

@Kirill89 Kirill89 force-pushed the fix/update-typescript-library branch from 96b9245 to 9b11502 Compare October 3, 2018 12:16
@Kirill89 Kirill89 force-pushed the fix/update-typescript-library branch from b3cde56 to f4e9c34 Compare October 3, 2018 12:25
@lili2311 lili2311 closed this Oct 3, 2018
@lili2311 lili2311 reopened this Oct 3, 2018
@miiila
Copy link
Contributor

miiila commented Oct 4, 2018

@Kirill89 Looks good, just a one question - String.prototype.endsWith() is not supported in es5, but is supported for Node 4 (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith).

I wonder what right setup is here... even after reading lot of things, I'm still unsure :-D

Copy link
Contributor

@miiila miiila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Kirill89 Kirill89 closed this Oct 4, 2018
@Kirill89 Kirill89 reopened this Oct 4, 2018
@miiila miiila closed this Oct 4, 2018
@miiila miiila reopened this Oct 4, 2018
@miiila miiila closed this Oct 4, 2018
@miiila miiila reopened this Oct 4, 2018
@Kirill89 Kirill89 merged commit 4254065 into master Oct 4, 2018
@Kirill89 Kirill89 deleted the fix/update-typescript-library branch October 4, 2018 14:02
@snyksec
Copy link

snyksec commented Oct 5, 2018

🎉 This PR is included in version 1.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants