feat: added initial dependencies parser implementation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirill89
force-pushed
the
feat/cherry-pick-line-parser
branch
from
16b704f
to
4ece5fe
Compare
Kirill89
force-pushed
the
feat/dependencies-parser
branch
from
4a30359
to
5056b89
Compare
Kirill89
changed the base branch from
feat/cherry-pick-line-parser
to
master
3 tasks
orsagie
reviewed
Feb 11, 2019
| const parts = line.match(re).splice(1); | ||
| const [repo, version] = parts[0].split(':'); | ||
|
|
||
| return { |
There was a problem hiding this comment.
Should we do some validation in case the file we get is not valid according to what we know?
We could just log it in debug mode for now if it's irrelevant to getting the dependencies themselves.
There was a problem hiding this comment.
I would ratter ignore this for now and fail with default out of bounds exception. We need to replace line parser with proper tokenizer anyway, let's do it there?
orsagie
approved these changes
Feb 11, 2019
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added initial dependencies parser implementation.
TODOs:
nugetdependency optionsparseGroupOptionclitoolsourcegitsourcegistsourcehttpsourceBut I believe we can continue without it for now.