snyk: append the error text to thrown errors #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adrukh
reviewed
Feb 26, 2018
lib/index.js
Outdated
| @@ -37,7 +37,7 @@ function inspect(root, targetFile, options) { | |||
| if (thrownError) { | |||
| throw thrownError; | |||
| } | |||
| throw new Error('An unknown error occurred.'); | |||
| throw new Error('snyk-sbt-plugin error: ' + error); | |||
There was a problem hiding this comment.
Converting an error to a string will only keep its message. How about just throw error; to keep the stack-trace etc.?
Also, how will the CLI behave on a standard error being thrown by the plugin?
There was a problem hiding this comment.
The CLI will just print the message and quit (without the stacktrace)
There was a problem hiding this comment.
b.t.w the existing code assumes the error is a string ..
adrukh
approved these changes
Feb 26, 2018
michael-go
force-pushed
the
fix/throw-more-informative-erros
branch
from
efb057c
to
6317c93
Compare
instead of current 'An unknown error occurred.' when e.g. `sbt` in not in the PATH
michael-go
force-pushed
the
fix/throw-more-informative-erros
branch
from
6317c93
to
ebf08c3
Compare
adrukh
approved these changes
Feb 26, 2018
adrukh
reviewed
Feb 26, 2018
| if (thrownError) { | ||
| throw thrownError; | ||
| } | ||
| throw new Error('snyk-sbt-plugin error: ' + error); |
There was a problem hiding this comment.
I'd do throw (thrownError ? thrownError : new Error('snyk-sbt-plugin error: ' + error));, but I'm weird.
There was a problem hiding this comment.
🙈 it becomes longer than 80 chars so I'll stick with my verbose version 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of current 'An unknown error occurred.' when e.g.
sbtis not in the PATH