fix: vendor tree-kill #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
|
robcresswell
force-pushed
the
fix/vendor-tree-kill
branch
2 times, most recently
from
0e28efb
to
384121a
Compare
lili2311
reviewed
Dec 6, 2019
robcresswell
force-pushed
the
fix/vendor-tree-kill
branch
from
384121a
to
43de8c7
Compare
darscan
approved these changes
Dec 6, 2019
robcresswell
added a commit
to snyk/cli
that referenced
this pull request
Dec 6, 2019
The `tree-kill` package, introduced by `snyk-sbt-plugin` has a RCE vulnerability. This patch raises the version of `snyk-sbt-plugin` to remove the vulnerability. See snyk/snyk-sbt-plugin#72 for further information
The `tree-kill` package has an RCE issue because the `pid` input is passed unsanitised to an `exec` command. To work around this, we are vendoring the code and adding some basic checks to make sure the pid is valid. Also adding a `.npmrc` file to prevent `package-lock.json` being generated, and moved `debug` to prod deps because its used in `lib/`
robcresswell
force-pushed
the
fix/vendor-tree-kill
branch
from
43de8c7
to
0fcbf48
Compare
gitphill
approved these changes
Dec 6, 2019
lili2311
reviewed
Dec 6, 2019
| @@ -28,17 +28,16 @@ | |||
| "devDependencies": { | |||
| "@types/node": "6.14.6", | |||
| "@types/sinon": "7.0.11", | |||
| "debug": "^4.1.1", | |||
There was a problem hiding this comment.
is it meant to move to prod deps?
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tree-killpackage has an RCE issue because thepidinput is passed unsanitised to anexeccommand. To work around this, we are vendoring the code and adding some basic checks to make sure the pid is valid.Also adding a
.npmrcfile to preventpackage-lock.jsonbeing generated, and moveddebugto prod deps because its used inlib/