docs: add some TODOs for the next major release

socketio · Jan 10, 2023 · 33dc073 · 33dc073
1 parent d0fd474
commit 33dc073
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/socket.ts b/lib/socket.ts
@@ -10,6 +10,7 @@ const debug = debugModule("engine:socket");
 
 export class Socket extends EventEmitter {
   public readonly protocol: number;
+  // TODO for the next major release: do not keep the reference to the first HTTP request, as it stays in memory
   public readonly request: IncomingMessage;
   public readonly remoteAddress: string;
 

diff --git a/lib/transports/polling.ts b/lib/transports/polling.ts
@@ -75,6 +75,7 @@ export class Polling extends Transport {
       debug("request overlap");
       // assert: this.res, '.req and .res should be (un)set together'
       this.onError("overlap from client");
+      // TODO for the next major release: use an HTTP 400 status code (https://github.com/socketio/engine.io/issues/650)
       res.writeHead(500);
       res.end();
       return;
@@ -116,6 +117,7 @@ export class Polling extends Transport {
     if (this.dataReq) {
       // assert: this.dataRes, '.dataReq and .dataRes should be (un)set together'
       this.onError("data request overlap from client");
+      // TODO for the next major release: use an HTTP 400 status code (https://github.com/socketio/engine.io/issues/650)
       res.writeHead(500);
       res.end();
       return;