Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript error using http2 server #4434

Closed
Jayce53 opened this issue Jul 27, 2022 · 2 comments
Closed

Typescript error using http2 server #4434

Jayce53 opened this issue Jul 27, 2022 · 2 comments
Labels
bug Something isn't working
Milestone
4.5.3

Comments

@Jayce53
Copy link

Jayce53 commented Jul 27, 2022

Describe the bug
The socket.io Server constructor types do not include Http2SecureServer so there's a type error when instantiating a Server as per the documentation HTTP/2 example.

To Reproduce

Socket.IO server version: 4.5.1

Server
Example directly from documentation

Example in Typescript Playground

Expected behavior
No typescript errors
@Jayce53 Jayce53 added the to triage Waiting to be triaged by a member of the team label Jul 27, 2022
@zefir-git
Copy link

I believe I have the same error in #4494 as well

darrachequesne added a commit that referenced this issue Oct 14, 2022
@darrachequesne
fix(typings): accept an HTTP2 server in the constructor
d3d0a2d 
Related:

- #4434
- #4494
@darrachequesne
Copy link
Member

Fixed by d3d0a2d, included in 4.5.3. Thanks 👍

@darrachequesne darrachequesne added bug Something isn't working and removed to triage Waiting to be triaged by a member of the team labels Oct 15, 2022
@darrachequesne darrachequesne added this to the 4.5.3 milestone Oct 15, 2022
dzad pushed a commit to dzad/socket.io that referenced this issue May 29, 2023
@darrachequesne
fix(typings): accept an HTTP2 server in the constructor
647dd98 
Related:

- socketio#4434
- socketio#4494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.5.3
Development

No branches or pull requests
3 participants
@Jayce53 @darrachequesne @zefir-git