Failed namespace authorization should fire 'connect_failed', not 'error' event

[fodor0205]

Documentation says:
"Failed authorizations are handled a bit differently than global authorization requests. Instead of emitting an error event we emit a connect_failed event."

But it fires the 'error' event.

I have written a small testcase for this:

• Server side: https://gist.github.com/b347ac0c61f7a7ca907a
• Client side: https://gist.github.com/2dd5a2e00777870058d8

My socket.io is v0.8.4

[josephg]

+1

[manast]

+1

[Wizek]

+1

[zoowar]

If you omit the message string it will fire "connect_failed"

cb(null, false); => fires "connect_failed"
cb("message", false); => fires "error"

[peica]

Why not update the document to mention this behavior?

If you omit the message string it will fire "connect_failed"

cb(null, false); => fires "connect_failed"
cb("message", false); => fires "error"

[manast]

Furthermore, if you use one of the predefined "reasons" you will get
connect_failed as well:

cb("unauthorized") -> "connect_failed" (Note that you don't need to
specify the last parameter if authentication failed.

Read more here:
#331

On Tue, 19 Jun 2012 23:47:05 -0700, peica wrote:

Why not update the document to mention this behavior?

If you omit the message string it will fire "connect_failed"

cb(null, false); => fires "connect_failed"
cb("message", false); => fires "error"

---

Reply to this email directly or view it on GitHub:

#524 (comment)