Support mac M1(osx-aarch_64) compile and test #1305
Conversation
Signed-off-by: crazyhzm <[email protected]>
|
Hi @CrazyHZM, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
WalkthroughThe update involves a significant version bump for Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -14,6 +14,7 @@ | |||
| <properties> | |||
| <main.user.dir>${basedir}/../../..</main.user.dir> | |||
| <sofa.rpc.compiler.version>0.0.3</sofa.rpc.compiler.version> | |||
| <protobuf.protoc.version>3.17.3</protobuf.protoc.version> | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Review Summary
The task was to verify the compatibility of the updated protobuf.protoc.version to 3.17.3 in the context of the entire project, particularly checking how it aligns with the ${protobuf.version} used in the sofaboot-dependencies pom.xml.
Analysis of Shell Script Output
The executed script successfully located the definition of ${protobuf.version} in the sofaboot-dependencies pom.xml. The output reveals that ${protobuf.version} is set to 3.22.2. This version is used as a dependency version for protobuf-related artifacts within the project.
Conclusion
The protobuf.protoc.version has been updated to 3.17.3 in the rpc-sofa-boot module, while the protobuf.version used across the project in the BOM is 3.22.2. This discrepancy suggests that the protobuf compiler version (protoc) and the protobuf library version used in the project are not aligned. This could potentially lead to compatibility issues, as the protobuf compiler version should ideally match the protobuf library version to ensure consistent behavior.
Action
It is recommended to align the protobuf.protoc.version with the protobuf.version used across the project to avoid potential compatibility issues. The developers should consider updating the protobuf.protoc.version to 3.22.2 to match the protobuf library version specified in the BOM.
Updated `protobuf.protoc.version` to `3.17.3` to support macOS M1 systems. However, it is recommended to align this version with the `protobuf.version` (`3.22.2`) used across the project to ensure compatibility.
Analysis chain
Updated protobuf.protoc.version to 3.17.3 to support macOS M1 systems.
Review Summary
The review comment concerns the update of the protobuf.protoc.version to 3.17.3 in the sofa-boot-core/rpc-sofa-boot/pom.xml file. The purpose of this update is to support macOS M1 systems. The review comment suggests verifying the compatibility of this updated version with other dependencies.
Analysis of Shell Script Output
The output from the executed shell script shows references to protobuf in various pom.xml files within the project:
- sofa-boot-tests/sofa-boot-smoke-tests/sofa-boot-smoke-tests-rpc/pom.xml - This file also uses the updated
protobuf.protoc.versionof3.17.3. - sofa-boot-project/sofaboot-dependencies/pom.xml - This file defines a
protobuf-bomwith a version placeholder${protobuf.version}and referencesprotobuf-java.
Conclusion
The update to protobuf.protoc.version to 3.17.3 is consistently used in another module (sofa-boot-smoke-tests-rpc). Additionally, the sofaboot-dependencies manages a Bill of Materials (BOM) for protobuf, which suggests centralized management of protobuf versions across the project. However, the exact value of ${protobuf.version} used in the BOM is not directly verified from the output.
Given that the updated version is used in multiple places and managed via a BOM, it is likely that the update is compatible with the project's dependencies. However, the exact version used in the BOM (${protobuf.version}) should be confirmed to ensure complete compatibility.
Action
To fully verify the compatibility and ensure that the ${protobuf.version} placeholder aligns with the updated 3.17.3 version, further investigation into the value of ${protobuf.version} is necessary.
Review Summary
The task was to verify the compatibility of the updated protobuf.protoc.version to 3.17.3 across the project, particularly in relation to the ${protobuf.version} placeholder used in the sofaboot-dependencies pom.xml.
Analysis of Shell Script Output
The executed script aimed to extract the value of ${protobuf.version} from the sofaboot-dependencies pom.xml. Unfortunately, the script did not produce any output, indicating that the protobuf.version property might not be defined within the <properties> section as expected, or the search parameters were not correctly set to capture the relevant data.
Conclusion
The absence of output suggests that the ${protobuf.version} might not be explicitly defined in the expected section of the pom.xml, or there could be an issue with how the search was conducted. This uncertainty prevents a definitive conclusion about the compatibility of the protobuf version across the project.
Action
Given the lack of conclusive data from the previous script, a more thorough search in the sofaboot-dependencies pom.xml is necessary to locate the definition of ${protobuf.version} or confirm its absence.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify if the updated protobuf version is compatible with other dependencies.
rg --type xml '<dependency>' -C 10 | grep 'protobuf'
Length of output: 841
Script:
#!/bin/bash
# Extract the value of ${protobuf.version} from the sofaboot-dependencies pom.xml
rg --type xml '<properties>' -A 20 sofa-boot-project/sofaboot-dependencies/pom.xml | grep 'protobuf.version'
Length of output: 108
Script:
#!/bin/bash
# Search for any occurrence of protobuf.version in the sofaboot-dependencies pom.xml
rg 'protobuf.version' sofa-boot-project/sofaboot-dependencies/pom.xml
Length of output: 176
protoc 3.7.1 don't support osx-aarch_64
https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.7.1/
Minimum supported version is 3.17.3:
https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.17.3/
Summary by CodeRabbit
protobuflibrary version to3.17.3to ensure compatibility and enhance performance.