Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backwards compat for GITHUB_TOKEN from env #133

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

softprops
Copy link
Owner

@softprops softprops commented Jul 30, 2021

fixes #132 that highlighted a regression in #83

@softprops softprops marked this pull request as ready for review July 30, 2021 22:39
@@ -42,7 +41,7 @@ export const parseInputFiles = (files: string): string[] => {

export const parseConfig = (env: Env): Config => {
return {
github_token: getInput("token") || env.GITHUB_TOKEN || "",
github_token: env.GITHUB_TOKEN || env.INPUT_TOKEN || "",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note all inputs are just env variables prefixed with INPUT_. we gain easy unit testability from leveraging this fact

@softprops softprops merged commit 8779b82 into master Jul 30, 2021
@softprops softprops deleted the fix-github-token-backwards-compat branch July 30, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not trigger other workflows anymore
1 participant