Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tasks & configurations, add shared testConfig #343

Merged
merged 10 commits into from
Dec 17, 2020

Conversation

xeruf
Copy link
Member

@xeruf xeruf commented Dec 2, 2020

This hopefully concludes the rampage in the last few days that ate up so many precious hours, trying to understand Gradle in depth.

One of the most important learnings & new features is a shared sourceset in the sdk, which via a configuration is depended upon in all projects to sync the KotestConfig and make util classes (currently only XStreamMatcher) available without exposing internals.
Other than that there are a few cleanups and fixes, nothing ground-breaking but generally improved cleanliness. @SKoschnicke should especially check the docker changes (7a93580).

Some related reading material:

server/build.gradle.kts Show resolved Hide resolved
@xeruf xeruf self-assigned this Dec 11, 2020
Copy link
Contributor

@SKoschnicke SKoschnicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xeruf xeruf merged commit f27d2f6 into master Dec 17, 2020
@xeruf xeruf deleted the chore/gradle-cleanup branch December 17, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants