geat(plugin): implement cloning for GameState & Board #356
Conversation
| && board == other.board | ||
| && lastMove == other.lastMove | ||
| && lastMoveMono == other.lastMoveMono | ||
| && turn == other.turn) |
There was a problem hiding this comment.
Since Kotlin doesn't have enforced semicolon to mark line endings, in ambigous cases of multi-line statements you need to put the operator at the end of the previous line (which is why || has to be at the end of the line).
Thus I think it's cleaner to put every operator of multi-line statements at the end of the line, rather than the beginning
There was a problem hiding this comment.
though having the operators aligned improves readability imo 🤔
There was a problem hiding this comment.
no, the || can also be at the beginning of the line, this isn't really an ambiguous case.
There was a problem hiding this comment.
oh, really?
I thought it couldn't know the return continues over several lines.
But maybe they just fixed that already
There was a problem hiding this comment.
If it's possible I wonder why you don't put the || at the beginning of the next line. That should improve readability even more, then
There was a problem hiding this comment.
because then it would be in front of the parentheses and thus not aligned either.
| <field x="8" y="6" content="YELLOW"/> | ||
| <field x="5" y="9" content="BLUE"/> | ||
| </board> | ||
| <lastMoveMono class="linked-hash-map"/> |
There was a problem hiding this comment.
is it fine to just reorder the XML?
There was a problem hiding this comment.
Depends on how the pupils parse it 😕 I would prefer to not change it mid-season.
| field = 1 + turn / orderedColors.size | ||
| return field | ||
| } | ||
| internal val validColors: MutableSet<Color> = |
There was a problem hiding this comment.
How about a comment explaining what validColors is?
| <field x="8" y="6" content="YELLOW"/> | ||
| <field x="5" y="9" content="BLUE"/> | ||
| </board> | ||
| <lastMoveMono class="linked-hash-map"/> |
There was a problem hiding this comment.
Depends on how the pupils parse it 😕 I would prefer to not change it mid-season.
|
It changes depending on the ordering of the fields in the class, which seems much more sensible to me now. |
xeruf
changed the title
- implement Gamestate equality correctly - implement cloning for GameState & Board - slight GameState XML change due to reorderings
No description provided.