Gradle: Improve configuration & TestClient build #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jar task was resolving the default configuration in the configuration phase, leading to spurious failure when executing any task in the testclient directly.
It was only because of two constants...
xeruf
force-pushed
the
chore/gradle/fix-tasks
branch
from
b1678a2
to
f1d2f0e
Compare
SKoschnicke
reviewed
Jan 21, 2021
There was a problem hiding this comment.
:test-client:jar does not fail in master.
In master (17ca22ab):
$ ./gradlew :test-client:jar
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true
> Configure project :
Current version: 21.2.1 Game: blokus_2021 (Java version: 11)
Java version 1.8 is recommended - expect issues with generating documentation (consider using '-x doc' if you don't care)
> Task :server:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/sven/development/sc/backend/server/src/sc/server/gaming/GameRoom.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.8/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 4s
10 actionable tasks: 10 executed
in this branch
$ ./gradlew clean && ./gradlew :test-client:jar
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true
> Configure project :
Current version: 21.2.1 Game: blokus_2021 (Java version: 11)
Java version 1.8 is recommended - expect issues with generating documentation (consider using '-x doc' if you don't care)
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.8/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 721ms
6 actionable tasks: 5 executed, 1 up-to-date
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true
> Configure project :
Current version: 21.2.1 Game: blokus_2021 (Java version: 11)
Java version 1.8 is recommended - expect issues with generating documentation (consider using '-x doc' if you don't care)
> Task :server:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/sven/development/sc/backend/server/src/sc/server/gaming/GameRoom.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.8/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 2s
9 actionable tasks: 9 executed
| } | ||
|
|
||
| dependencies { | ||
| implementation(project(":plugin")) | ||
| // TODO this dependency is only for accessing the Configuration, remove it |
There was a problem hiding this comment.
remove it... now? Or when?
|
That is interesting, I get this on master: ❯ ./gradlew :test-client:jar
Picked up _JAVA_OPTIONS: -Djava.util.prefs.userRoot=/home/janek/.config/java
Configuration on demand is an incubating feature.
> Configure project :
Current version: 21.2.1 Game: blokus_2021 (Java version: 1.8)
FAILURE: Build failed with an exception.
* Where:
Build file '/home/janek/data/1-projects/software-challenge/gui/backend/server/build.gradle.kts' line: 3
* What went wrong:
An exception occurred applying plugin request [id: 'org.gradle.application']
> Failed to apply plugin class 'org.gradle.api.distribution.plugins.DistributionPlugin'.
> Project#afterEvaluate(Action) on project ':server' cannot be executed in the current context. |
|
Java version isn't the issue either: ❯ ./gradlew :test-client:jar
Picked up _JAVA_OPTIONS: -Djava.util.prefs.userRoot=/home/janek/.config/java
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details
Configuration on demand is an incubating feature.
> Configure project :
Current version: 21.2.1 Game: blokus_2021 (Java version: 11)
Java version 1.8 is recommended - expect issues with generating documentation (consider using '-x doc' if you don't care)
FAILURE: Build failed with an exception.
* Where:
Build file '/home/janek/data/1-projects/software-challenge/gui/backend/server/build.gradle.kts' line: 3
* What went wrong:
An exception occurred applying plugin request [id: 'org.gradle.application']
> Failed to apply plugin class 'org.gradle.api.distribution.plugins.DistributionPlugin'.
> Project#afterEvaluate(Action) on project ':server' cannot be executed in the current context. |
|
Interesting, combining it with clean makes it work: ❯ ./gradlew clean :test-client:jar
Picked up _JAVA_OPTIONS: -Djava.util.prefs.userRoot=/home/janek/.config/java
Configuration on demand is an incubating feature.
> Configure project :
Current version: 21.2.1 Game: blokus_2021 (Java version: 1.8)
> Task :server:compileJava
Note: /home/janek/data/1-projects/software-challenge/gui/backend/server/src/sc/server/network/PerspectiveAwareConverter.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/janek/data/1-projects/software-challenge/gui/backend/server/src/sc/server/gaming/GameRoom.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.8/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 9s
16 actionable tasks: 15 executed, 1 up-to-dateEither way, it was unreliable and is now better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if you don't understand it, please have a glance at it and run a few tasks locally
:test-client:jar, if run independently, should fail on master but work on this branchYou probably won't notice any big differences, but architecturally the code is now a lot cleaner and my gradle understanding improved a lot as well after hours of tinkering with it. Feel free to ask what the changes do, too.