Improve SDK exceptions #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeruf
force-pushed
the
sdk/exceptions
branch
from
5fdf1d7
to
af8a1c1
Compare
SKoschnicke
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Looks good.
The sense behind the exception hierarchy is lost, I'm afraid (I didn't program that).
Maybe we should add comments to the new exceptions describing what they are for and how the expected behavior of the server and client should be if such an exception happens? To make sure that the sense is not lost again.
| try { | ||
| ReservationManager.redeemReservationCode(source, packet.reservationCode) | ||
| } catch(e: RescuableClientException) { | ||
| source.send(ProtocolErrorMessage(packet, e.message)) |
There was a problem hiding this comment.
So the exceptions are now sent here to the client instead having the handleInvalidMove method for that, right?
There was a problem hiding this comment.
no, this change has nothing to do with moves. Please look into the individual commits for coherence.
xeruf
force-pushed
the
sdk/exceptions
branch
from
81c737f
to
b7e6bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was mir allerdings noch ein Rätsel ist: ein Client stoppt bei einer
RescuableClientExceptionsofort - wozu ist sie dannRescuable? Bei nem falschen Reservierungscode oder so kann der Client doch weiterhin verbunden bleiben?FYI some visualizations:
