Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): improve GameState turn advancing #391

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

xeruf
Copy link
Member

@xeruf xeruf commented Feb 15, 2021

  • turn can now only be modified by GameState itself
  • GameState automatically skips invalid colors when advancing
  • improved corresponding testing

@Coronon bitte testen wenn du es schaffst :)

- turn can now only be modified by GameState itself
- GameState automatically skips invalid colors when advancing
- improved corresponding testing
@Coronon
Copy link

Coronon commented Feb 15, 2021

Werden wir Morgen mal machen, dafür müssen wir nämlich sämtliche Tools nochmal umschreiben + den Client an die jetzt richtigen Turns anpassen

@Coronon
Copy link

Coronon commented Feb 15, 2021

@xerus2000 Haben uns tatsächlich Heute schon drangesetzt, es hat sich absolut nichts verändert :/

@xeruf
Copy link
Member Author

xeruf commented Feb 16, 2021

seltsam, laut tests sieht jetzt alles korrekt aus... danke für das feedback :)

@xeruf
Copy link
Member Author

xeruf commented Feb 16, 2021

Habe beispielhaft das Ende eines Spiels angeschaut, da sah alles korrekt aus:

turn - color
59   - green
60   - blue
61   - yellow
65   - yellow
69   - yellow

Kannst du nochmal ein Beispiel liefern? Wie baust du denn diese Server-version? Branch auschecken und nach ./gradlew clean deploy die jars aus build/deploy/ holen?

@Coronon
Copy link

Coronon commented Feb 16, 2021

-> Missverständnis, ist also richtig

@xeruf xeruf changed the title fix(plugin): improve GameState advancing for more logical turn counting fix(plugin): improve GameState turn advancing Feb 22, 2021
@xeruf xeruf merged commit cb4b31d into master Feb 22, 2021
@xeruf xeruf deleted the fix/plugin/advance branch February 22, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants