Bench tps fixes #735
Merged
Bench tps fixes #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advertised by the client
mvines
reviewed
Jul 23, 2018
src/bin/bench-tps.rs
Outdated
| @@ -151,13 +153,14 @@ fn generate_and_send_txs( | |||
| txs as f32 / (duration_as_s(&transfer_start.elapsed())) | |||
| ); | |||
|
|
|||
| loop { | |||
| // try for 5s to get a new last_id | |||
There was a problem hiding this comment.
Should we log something angry or just abort if we don’t find a new last_id?
There was a problem hiding this comment.
Yea. I will add a message and an exit(1).
mvines
reviewed
Jul 23, 2018
src/bin/bench-tps.rs
Outdated
| } else { | ||
| num_txs = balance; | ||
| } | ||
| println!( |
There was a problem hiding this comment.
Yay thanks for merging these two loops, I was going to do that later today!
mvines
approved these changes
Jul 23, 2018
sakridge
force-pushed
the
bench-tps-fixes
branch
from
3f64363
to
06f970e
Compare
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…na-labs#735) Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins) from 15.1.0 to 16.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](rollup/plugins@commonjs-v15.1.0...commonjs-v16.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Apr 11, 2024
…na-labs#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet.
yihau
pushed a commit
that referenced
this pull request
Apr 11, 2024
…t (backport of #735) (#742) quic: use smallvec to aggregate chunks, save 1 alloc per packet (#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
yihau
pushed a commit
that referenced
this pull request
Apr 11, 2024
…t (backport of #735) (#741) quic: use smallvec to aggregate chunks, save 1 alloc per packet (#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # Cargo.lock # Cargo.toml # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 12, 2024
…t (backport of solana-labs#735) (solana-labs#741) quic: use smallvec to aggregate chunks, save 1 alloc per packet (solana-labs#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # Cargo.lock # Cargo.toml # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 13, 2024
…na-labs#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet.
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 18, 2024
…na-labs#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet.
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 24, 2024
…t (backport of solana-labs#735) (solana-labs#742) quic: use smallvec to aggregate chunks, save 1 alloc per packet (solana-labs#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.