fix: binary data not working as described (fixes #289, #231) #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RSLak1 is there anything else necessary for this PR to be merged ? |
|
@alexandrehebert I am not a maintainer of this project and therefore cannot merge this PR. |
alexandrehebert
approved these changes
Jul 6, 2022
|
published as + qrcode@1.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed binary data not working as input as described in the README.md.
Fixes #289, fixes #231.
Tests were also added, one unit test and one e2e test, each in its own commit.
Note:
I wasnt sure whether or not the place for the fix was right. I could also adapt
ByteDatato only acceptArrayBufferor similar and make the string conversion in the files using this class (e.g.segments.js). Please let me know it you want me to change that.