Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode api url components #1604

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

rvlzzr
Copy link
Contributor

@rvlzzr rvlzzr commented Aug 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

API routes with paths containing international characters are never matched and do not work.

What is the new behavior?

API routes containing international characters match and work as expected, consistent with other file routes.

Other information

For example an API route "/api/거" will never be matched currently. I don't think even naming the file/directory "%EA%B1%B0" (which would be an ugly workaround regardless) works here, so there is no way to accomplish this with the current broken behavior.

Normal file routes like "/거" match and work correctly, so this change makes API routes behave consistently with other routes.

Copy link

changeset-bot bot commented Aug 18, 2024

🦋 Changeset detected

Latest commit: 88550e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid
Copy link
Member

Thank you

@ryansolid ryansolid merged commit 7ae221b into solidjs:main Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants