Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of deprecated version of Node.js #2194

Merged

Conversation

hamirmahal
Copy link
Contributor

fixes #2193.

Summary

The current version of coverallsapp/github-action uses a deprecated version of Node.js.

How did you test this change?

I made sure the job test still passes.

Copy link

changeset-bot bot commented Jun 18, 2024

⚠️ No Changeset found

Latest commit: db6a254

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -31,7 +31,7 @@ jobs:
pnpm run coverage

- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the latest major version at the time of this writing.

@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9573806690

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.56%

Totals Coverage Status
Change from base Build 9454550797: 0.0%
Covered Lines: 4186
Relevant Lines: 4408

💛 - Coveralls

@ryansolid ryansolid merged commit cba4eee into solidjs:main Jun 21, 2024
1 check passed
@ryansolid
Copy link
Member

Thank you

@hamirmahal
Copy link
Contributor Author

You're welcome.

@hamirmahal hamirmahal deleted the fix/usage-of-deprecated-version-of-nodejs branch June 21, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current version of coverallsapp/github-action uses a deprecated version of Node.js
3 participants