Remove ACL tags from BM #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-pritsak
force-pushed
the
notag
branch
2 times, most recently
from
2cbf486
to
600a022
Compare
|
This is a manual revert of #336 |
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
|
@prsunny @KrisNey-MSFT Can you take a look? |
|
LGTM, will wait to hear from @prsunny |
kperumalbfn
approved these changes
Aug 30, 2023
|
[like] Kristina Moore reacted to your message:
…________________________________
From: Kumaresh Perumal ***@***.***>
Sent: Wednesday, August 30, 2023 4:29:04 PM
To: sonic-net/DASH ***@***.***>
Cc: Kristina Moore ***@***.***>; Mention ***@***.***>
Subject: Re: [sonic-net/DASH] Remove ACL tags from BM (PR #425)
@kperumalbfn approved this pull request.
—
Reply to this email directly, view it on GitHub<#425 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6HWLW5KCASTWRDNAULXX5S5BANCNFSM6AAAAAA3V5D6YM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
3 ppl reviewed, merging |
|
@marian-pritsak and @prsunny - the ACL tagging is removed from P4 code. Do we also want to remove it from the SONiC DASH HLD documentation? Or leave it there, in case some suppliers would want the information? We had mentioned removing it from docs in Issue421 |
I suggest leave it there. |
clarklee-guizhao
added a commit
to clarklee-guizhao/DASH
that referenced
this pull request
Dec 3, 2023
* main: (75 commits) [dash-SAI] Enable warnings as errors (sonic-net#466) [SAI] wrong code generated in libsai sonic-net#415 (sonic-net#463) Fix incorrect IP in SONiC-DASH HLD VNET to VNET example. (sonic-net#459) DASH pipeline packet flow update proposal. (sonic-net#449) [libsai] Add attr name logging when doing get api (sonic-net#451) Build libsai deb packages in github workflow (sonic-net#450) Add Private Link mapping (sonic-net#327) [SAI] Update SAI submodule to the latest origin/master (sonic-net#446) [dash] Add libsai-debs target to create libsai debian packages (sonic-net#444) update p4 compile dependancy to avoid parallel docker runs (sonic-net#443) [dash] Refactor libsai (sonic-net#438) [dash] Update SAI to latest v1.13 (sonic-net#435) [dash-pipeline] Refactor Makefiles (sonic-net#432) Remove ACL tags from BM (sonic-net#425) [submodule] Update SAI submodule to origin/master (sonic-net#431) [sai-api-gen] Write files only when changes are detected (sonic-net#429) Adds SAI_ROUTE_ENTRY_ATTR_PACKET_ACTION api to dash_underlay_routing (sonic-net#422) [SAI] Add missing check for api initialized [SAI] Print oids in hex form [SAI] Change asserts to return error codes and add missing switch api ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #421