Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update CI to ensure SAI spec are generated and updated. #595

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Jun 23, 2024

To help the code review of SAI header updates, update the CI workflow to ensure we have up-to-date SAI spec included in the PR.

This is achieved by checking git status and see if any changes in the SAI/specs folder, after running make sai in the CI pipeline.

@r12f r12f changed the title [CI] Update CI to ensure SAI spec are generated and updated. [ci] Update CI to ensure SAI spec are generated and updated. (Pending #594) Jun 23, 2024
@r12f
Copy link
Collaborator Author

r12f commented Jun 23, 2024

Need #594 to be checked in to make it stable.

@r12f r12f marked this pull request as draft June 23, 2024 14:52
@r12f r12f requested a review from chrispsommers June 23, 2024 14:52
@r12f r12f changed the title [ci] Update CI to ensure SAI spec are generated and updated. (Pending #594) [ci] Update CI to ensure SAI spec are generated and updated. Jun 25, 2024
@r12f r12f marked this pull request as ready for review June 25, 2024 20:59
@KrisNey-MSFT
Copy link
Collaborator

hi @chrispsommers - did you happen to check this one? It had requested your review...TY, Kristina

@r12f r12f merged commit 9220af1 into sonic-net:main Jun 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants