Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc/sonic-front-pannel-port-prefix-regex.md #1092

Closed
wants to merge 4 commits into from

Conversation

itamar-talmon
Copy link

In order to support distinguishing between different types of front panel ports in a maintainable fashion.
Specifically, we are planning to bring up a system with 'service' ports (in addition to the regular ethernet data ports) - these
are lower speed ports that used for connection to accelerators, internal loopbacks and more.

@itamar-talmon
Copy link
Author

@lihuay - Hi I created new PR with the correct user (last one was not signed the CLA). Thanks.

@Blueve
Copy link
Contributor

Blueve commented Oct 3, 2022

@yxieca
Copy link
Contributor

yxieca commented Oct 17, 2022

Should this be a part of doc: https://github.com/sonic-net/SONiC/blob/master/doc/sonic-port-name.md ?

I agree with this suggestion. The design sounds benight but the actual change touches quite some code. Can we call out these areas needs to be changed?

@yxieca yxieca requested a review from prsunny October 17, 2022 22:48
@itamar-talmon
Copy link
Author

I will update https://github.com/sonic-net/SONiC/blob/master/doc/sonic-port-name.md and the scope of this change. Thanks

@itamar-talmon
Copy link
Author

@yxieca - I have updated https://github.com/sonic-net/SONiC/blob/master/doc/sonic-port-name.md and added details about the scope of this change. It is simple but touches many places.

@lguohan
Copy link
Contributor

lguohan commented Oct 23, 2022

@itamar-talmon , we should have a sync with @rlhui on what has already been added to chassis, i remember we have some internal links, loopback defined for chassis system. we need to check what exist today and see if some of the new things can be accomodated by chassis proposal already?

@yxieca yxieca requested a review from rlhui October 24, 2022 14:50
yxieca
yxieca previously approved these changes Oct 24, 2022
@itamar-talmon
Copy link
Author

Hi @rlhui - could you please review this proposal?

@itamar-talmon
Copy link
Author

I close this since I opened new one from a new branch that is not my master - #1777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants